fix wrong conditional for build custom_rules.tmpl.xml #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Dec 20, 2018
| @@ -483,7 +483,7 @@ def make_package(args): | |||
| join(res_dir, 'values/strings.xml'), | |||
| **render_args) | |||
|
|
|||
| if exists("custom_rules.tmpl.xml"): | |||
| if exists(join("templates", "custom_rules.tmpl.xml")): | |||
There was a problem hiding this comment.
I'm not sure how this works if you fixed the first path in the exists condition, but not the render one which I would have expected to be the same 🤔
There was a problem hiding this comment.
hi, because os.path.exists check on filesystem and not use jinja2.Environment, render it's a local function that use the jinja2.Environment.
There was a problem hiding this comment.
@AndreMiras it works because of this line:
(which sets up the environment to be located insidetemplates, so jinja2 naturally looks in there)
AndreMiras
approved these changes
Dec 20, 2018
| @@ -483,7 +483,7 @@ def make_package(args): | |||
| join(res_dir, 'values/strings.xml'), | |||
| **render_args) | |||
|
|
|||
| if exists("custom_rules.tmpl.xml"): | |||
| if exists(join("templates", "custom_rules.tmpl.xml")): | |||
|
Looking good thank you. I'm just restarting the build because it flaky failed and will merge pretty soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this, ant debug stop with message: